{{ message }}
Repository navigation
fix(cli): forward entrypoint skip_confirmation to the generated command - #609
Merged
ko3n1g merged 3 commits intoOct 2, 2026
Merged
Conversation
Entrypoint.skip_confirmation was stored but never forwarded to the generated CLI command, so @run.cli.entrypoint(skip_confirmation=True) still prompted 'Continue?' on every non-dryrun invocation (the --yes flag or run.skip_confirmation=True were required instead). _add_executor_command now seeds the command defaults with the entrypoint's skip_confirmation value. Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
ManoharPaturi
force-pushed
the
fix/entrypoint-skip-confirmation
branch
from
September 7, 2026 16:36
91e44c3 to
0972762
Compare
Contributor
|
/ok to test cd432d5 |
ko3n1g
approved these changes
Oct 2, 2026
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #608.
_add_executor_commandnow seedscmd_defaultswithskip_confirmation=Truefrom the entrypoint (viasetdefault, so an explicitcmd_defaultsfromrun.cli.main(...)still wins). The generated command option then defaults to True and_should_continuedoes not prompt.Test: invokes the generated command with
typer.confirmpatched to decline — on main the run never launches (prompt declined), with the fix it runs without prompting. Rest oftest/cli/unchanged.