fix(output): clear inherited report ACLs before writing by yashrajp22 · Pull Request #896 · NVIDIA/SkillSpector · GitHub
Skip to content

fix(output): clear inherited report ACLs before writing - #896

Open
yashrajp22 wants to merge 1 commit into
mainfrom
yashraj/fix-report-inherited-acls
Open

yashrajp22 wants to merge 1 commit into
mainfrom
yashraj/fix-report-inherited-acls

Conversation

@yashrajp22

@yashrajp22 yashrajp22 commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

On macOS, a report saved in a folder with inheritable ACL permissions could remain readable by other users even with mode 0600.

Clear inherited access from the already-open temporary file before writing report data, using the same protection as baseline files. If access cannot be restricted, preserve the old report and remove the temporary file. Baseline ownership, ACL preservation, and atomic writes keep their existing behavior.

Validation:

  • Fresh source and installed-wheel runs: 594 report/baseline tests passed in each mode; eight macOS-specific tests skipped on Linux.
  • All 20 report-format checks and 48 sample-skill scans passed, with matching findings and behavior after excluding generated IDs and scan metadata.
  • Native macOS checks reproduced the old exposure and confirmed its removal using the release candidate's source and wheel. The report and baseline helpers are byte-for-byte identical to this PR; this is shared-helper evidence, not a full macOS run of this main-branch wheel.
  • Lint, formatting, wheel packaging, and both independent review tools passed.

Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
(cherry picked from commit 58b7d0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant