Fix for ReadWriteMultipleRegisters by yipilipi · Pull Request #99 · NModbus4/NModbus4 · GitHub
Skip to content
This repository was archived by the owner on Jul 24, 2022. It is now read-only.

Fix for ReadWriteMultipleRegisters#99

Open
yipilipi wants to merge 1 commit into
NModbus4:portable-3.0from
yipilipi:portable-3.0
Open

Fix for ReadWriteMultipleRegisters#99
yipilipi wants to merge 1 commit into
NModbus4:portable-3.0from
yipilipi:portable-3.0

Conversation

@yipilipi

Copy link
Copy Markdown

Just discover ReadWriteMultipleRegister not working. TransportPDU is correctly handled but the override can't be called because , need to override messageframe to call it.
Fix ModbusRTUTransport to handle reply. Need to check TCP and ascii
Add case for handling ReadWriteMultipeRegisiters

Add case for handling ReadWriteMultipeRegisiters
@codecov-io

Copy link
Copy Markdown

@jikelmon

Copy link
Copy Markdown

Your fix works very well but i encountered that the read action is performed before the write action.
The modbus specification says that the write action has to be performed before the read action, doesn't it?
Would it be possible to change the behaviour of your patch to correspond with the official specification?

Best regards :)

@jacobbenlewis

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants