{{ message }}
Repository navigation
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the Linux Dockerfile from GCC 5 on Ubuntu 18.04 to Clang on Ubuntu 22.04 with SafeStack instrumentation.
Problem
The current build produces
liblua54.sothat fails BinSkim SDL validation:error BA2025 : 'liblua54.so' was compiled using Clang but without the SafeStack instrumentation pass.
Organizations with SDL compliance requirements cannot use the current binary in production Linux deployments.
Related issue: NLua/KeraLua#96
Changes
Ubuntu 18.04 -> Ubuntu 22.04 (LTS until 2027)
GCC 5 -> Clang
No security flags ->
-fsanitize=safe-stack