Improve CI by 304NotModified · Pull Request #259 · NLog/NLog.MailKit · GitHub
Skip to content

Improve CI - #259

Merged
304NotModified merged 14 commits into
masterfrom
ci
Oct 18, 2026
Merged

Improve CI#259
304NotModified merged 14 commits into
masterfrom
ci

Conversation

@304NotModified

@304NotModified 304NotModified commented Oct 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Moved to one file for build, test and publish.
  • SonarQube is not out of scope for now
  • DOTNET_SDK_VERSION and solution file to env
  • Every PR creates a NuGet package (but not pushed to nuget.org)
  • With force NuGet publish - also push non-master nuget package to nuget.org (the nuget version has the PR id eg, NLog.MailKit.6.1.5-pr259-ci.4.nupkg)

TODO:

This looks good to me:
image

See NLog/NLog#6306

github-advanced-security[bot]
github-advanced-security Bot found potential problems Oct 18, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml Fixed
@304NotModified
304NotModified marked this pull request as ready for review October 18, 2026 15:27
@304NotModified 304NotModified mentioned this pull request Oct 18, 2026
Closed
1 task
@304NotModified 304NotModified mentioned this pull request Oct 18, 2026
Open
snakefoot
snakefoot reviewed Oct 18, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml
snakefoot
snakefoot reviewed Oct 18, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
snakefoot
snakefoot reviewed Oct 18, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
snakefoot
snakefoot reviewed Oct 18, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml
@snakefoot

snakefoot commented Oct 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@304NotModified

304NotModified commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Kind of liked build-and-test.yml since not a big fan of acronym, unless giving a clear advantage. Maybe an alternative could be build-publish.yml ? Anyway if you really like ci.yml then I will not fight ya :)

I'm really dislike self-made acronyms haha

The down side of calling the Build and test as that name is also then twice in the PR checks, and I find that confusing:
image

@304NotModified
304NotModified requested a balanced review from Copilot October 18, 2026 18:09
Copilot AI reviewed Oct 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

sonarqubecloud Bot commented Oct 18, 2026

Copy link
Copy Markdown

@304NotModified
304NotModified merged commit 4313da6 into master Oct 18, 2026
8 checks passed
@304NotModified
304NotModified deleted the ci branch October 18, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snakefoot snakefoot snakefoot left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@304NotModified @snakefoot @github-advanced-security