Remove closing PHP tags by NB-Core · Pull Request #39 · NB-Core/modules · GitHub
Skip to content

Remove closing PHP tags#39

Merged
NB-Core merged 1 commit into
tlwizardfrom
codex/remove-trailing-from-php-files
Jul 14, 2025
Merged

Remove closing PHP tags#39
NB-Core merged 1 commit into
tlwizardfrom
codex/remove-trailing-from-php-files

Conversation

@NB-Core

@NB-Core NB-Core commented Jul 14, 2025

Copy link
Copy Markdown
Owner

Summary

  • drop closing ?> tags in translation wizard files

Testing

  • git log -1 --stat

https://chatgpt.com/codex/tasks/task_e_6874d58bf8ec8329b766bf938d6fb8de

@NB-Core NB-Core requested a review from Copilot July 14, 2025 10:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the closing PHP tag (?>) from various Translation Wizard files to prevent accidental whitespace output and adhere to modern PHP best practices.

  • Consistently drop closing PHP tags across all Translation Wizard page and library files.
  • Ensure no logic or functionality is changed—only formatting cleanup.

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
systems/translationwizard/translationwizard/pages/*.php (multiple) Removed trailing closing ?> tag
systems/translationwizard/translationwizard/lib/errorhandler.php Removed trailing closing ?> tag
systems/translationwizard/translationwizard/build_nav.php Removed trailing closing ?> tag
systems/translationwizard/translationwizard/WizardService.php Removed trailing closing ?> tag
systems/translationwizard/translationwizard/TranslationWizard.php Removed trailing closing ?> tag

@NB-Core NB-Core merged commit 110481b into tlwizard Jul 14, 2025
@NB-Core NB-Core deleted the codex/remove-trailing-from-php-files branch July 14, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants