{{ message }}
Refactor deleteEmpty namespace handling#33
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the handling of empty-namespace deletions in WizardService by introducing helper methods to avoid duplicated SQL and updating the existing deleteEmpty() method to use them.
- Added private helpers
getEmptyNamespaceRows()anddeleteEmptyNamespaceRows() - Updated
deleteEmpty()to replace inline SQL with the new helper calls
Comments suppressed due to low confidence (1)
systems/translationwizard/translationwizard/WizardService.php:213
- Consider adding unit or integration tests for getEmptyNamespaceRows() and deleteEmptyNamespaceRows() to verify they correctly retrieve and delete rows without a namespace as intended.
private static function getEmptyNamespaceRows() {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getEmptyNamespaceRows()anddeleteEmptyNamespaceRows()inWizardServicedeleteEmpty()instead of duplicating SQLTesting
php -l systems/translationwizard/translationwizard/WizardService.phphttps://chatgpt.com/codex/tasks/task_e_6874ba48e3dc8329878f08ac57d5faa9