{{ message }}
Refactor Translation Wizard markup#27
Merged
NB-Core merged 3 commits intoJul 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Translation Wizard pages to use the tw_form_* and tw_table_* helper functions instead of raw HTML, cleaning up markup and improving consistency across pages.
- Replace all raw
<form>tags withtw_form_open()andtw_form_close(). - Convert HTML
<table>constructs totw_table_open(),tw_table_row(), andtw_table_close(). - General markup cleanup and consistency improvements in all Translation Wizard pages.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
Comment on lines
+105
to
+126
There was a problem hiding this comment.
[nitpick] The repeated table setup (tw_table_open, tw_table_row, tw_table_close) appears across multiple pages. Consider extracting common table-rendering logic into a shared helper or component to reduce duplication.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NB-Core
deleted the
codex/update-form-and-table-markup-in-translationwizard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tw_form_openandtw_form_closeeverywhereTesting
php -l systems/translationwizard/translationwizard/pages/central_pull.phpphp -l systems/translationwizard/translationwizard/pages/central_push.phpphp -l systems/translationwizard/translationwizard/pages/default.phpphp -l systems/translationwizard/translationwizard/pages/remove_translated.phpphp -l systems/translationwizard/translationwizard/pages/searchandedit.phpphp -l systems/translationwizard/translationwizard/pages/searchandreplace.phpphp -l systems/translationwizard/translationwizard/pages/untranslated_list.phpphp -l systems/translationwizard/translationwizard/pages/known.phpphp -l systems/translationwizard/translationwizard/pages/overview.phpphp -l systems/translationwizard/translationwizard/WizardService.phphttps://chatgpt.com/codex/tasks/task_e_68741d4b82b08329967243b046e89408