{{ message }}
Improve translation wizard forms#18
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances user guidance and accessibility in the Translation Wizard by adding descriptive prompts before forms and translatable title attributes on textareas.
- Adds instructional text above form sections to clarify user actions.
- Introduces
titleattributes on original and translation textareas with translation support. - Updates prompts in push/pull/list modules for better context.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
Comments suppressed due to low confidence (4)
systems/translationwizard/translationwizard/searchandreplace.php:175
- Relying solely on the
titleattribute may not be accessible to all users; consider adding anaria-labelor visible<label>tied to this textarea for better screen reader support.
rawoutput("<textarea name='intext' class='input' cols='60' rows='5' title=\"".translate_inline('Original text')."\">".htmlentities(stripslashes($row['intext']),ENT_COMPAT,$coding)."</textarea>");
systems/translationwizard/translationwizard/edit_single.php:23
- Adding an
aria-labelor wrapping the textarea in a<label>element would improve accessibility, as relying ontitlealone may not be announced by screen readers.
rawoutput("<textarea name='intext' class='input' cols='60' rows='5' readonly title=\"".translate_inline('Original text')."\">".htmlentities(stripslashes(httpget('intext')),ENT_COMPAT,$coding)."</textarea><br/>");
systems/translationwizard/translationwizard/list.php:8
- [nitpick] Consider wrapping this instruction in a semantic heading (e.g.,
<h2>) or paragraph tag for clearer document structure and improved screen reader navigation.
output("Edit the selected texts below:");
systems/translationwizard/translationwizard/pull.php:84
- [nitpick] The original prompt included guidance about using the central DB by default; consider reintroducing that context or merging both instructions to avoid confusing users.
output("Select a mirror and directory to pull from:");
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
php -l systems/translationwizard/translationwizard/default.phpphp -l systems/translationwizard/translationwizard/edit_single.phpphp -l systems/translationwizard/translationwizard/searchandedit.phpphp -l systems/translationwizard/translationwizard/searchandreplace.phphttps://chatgpt.com/codex/tasks/task_e_6873f58ec3d88329be6200d3331caed8