{{ message }}
Refactor wizard forms#13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors all Translation Wizard pages to use the tw_form_open() and tw_form_close() helpers instead of manually injecting <form> tags via rawoutput(), while leaving forms with special name attributes untouched.
- Replaced raw
<form>open/close calls withtw_form_open()/tw_form_close()throughout the wizard. - Ensured each module’s form now correctly pairs open/close helpers.
- Left existing special-named forms (outside of
tw_form_*) intact.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
Comments suppressed due to low confidence (2)
systems/translationwizard/translationwizard/searchandreplace.php:161
- [nitpick] Indentation here is deeper than the surrounding code. Align the
tw_form_open()call with its matchingaddnav()to improve readability.
tw_form_open("searchandreplace&mode=save");
systems/translationwizard/translationwizard/known.php:143
- [nitpick] This
tw_form_open()call is not indented consistently with its surrounding block—consider normalizing indentation to match project style.
tw_form_open("known$redirect");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tw_form_open()andtw_form_close()in Translation Wizard pagesTesting
php -l systems/translationwizard/translationwizard/changescheme.phpphp -l systems/translationwizard/translationwizard/deleteempty.phpphp -l systems/translationwizard/translationwizard/edit_single.phpphp -l systems/translationwizard/translationwizard/editchecked.phpphp -l systems/translationwizard/translationwizard/fix.phpphp -l systems/translationwizard/translationwizard/insert_central.phpphp -l systems/translationwizard/translationwizard/known.phpphp -l systems/translationwizard/translationwizard/list.phpphp -l systems/translationwizard/translationwizard/push.phpphp -l systems/translationwizard/translationwizard/scanmodules.phpphp -l systems/translationwizard/translationwizard/searchandedit.phpphp -l systems/translationwizard/translationwizard/searchandreplace.phpphp -l systems/translationwizard/translationwizard/truncate.phphttps://chatgpt.com/codex/tasks/task_e_6873cfa5f8f08329883b84325ba0db59