Add viewer_open as new Kind by ac-61 · Pull Request #855 · NASA-AMMOS/MMGIS · GitHub
Skip to content

Add viewer_open as new Kind#855

Merged
ac-61 merged 4 commits into
developmentfrom
ac-open-viewer-kind
Jan 29, 2026
Merged

Add viewer_open as new Kind#855
ac-61 merged 4 commits into
developmentfrom
ac-open-viewer-kind

Conversation

@ac-61

@ac-61 ac-61 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

This adds viewer_open as a new Kind. This will zoom to a clicked feature and expand the Viewer panel if it is not already open.

Screenshot 2026-01-28 at 2 51 07 PM

This works on GeoJSON features with the following geometry types: Point, LineString, Polygon, MultiPoint, MultiLineString, and MultiPolygon.

For points, the map will zoom to the zoom level set in "Zoom Level of Map Scale" (found under the UI configuration), if it is set, otherwise it will use the current zoom level of the map. For all other geometry types, the map will zoom to the bounds of the feature.

mmgis_kinds_01

@ac-61 ac-61 requested review from fcalef and tariqksoliman January 28, 2026 23:41
@github-actions

github-actions Bot commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

@tariqksoliman tariqksoliman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm seeing that when selecting a feature with the viewer_open kind, if I pan or zoom away from the feature while it's still selected, it automatically snaps back to the feature. Could you make it so that it doesn't keep fixating on the features after the initial selection. Thanks!

@tariqksoliman tariqksoliman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't replicate the issue I found so I'm approving.

@ac-61 ac-61 changed the title Add viewer_open as new Kind Add viewer_open as new Kind Jan 29, 2026
@ac-61 ac-61 merged commit c1bee39 into development Jan 29, 2026
5 checks passed
@ac-61 ac-61 deleted the ac-open-viewer-kind branch January 29, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants