Added max-width to legend to prevent long text from filling screen by jtroberts · Pull Request #394 · NASA-AMMOS/MMGIS · GitHub
Skip to content

Added max-width to legend to prevent long text from filling screen#394

Merged
jtroberts merged 2 commits into
developmentfrom
jr-maxwidth-legend
Jul 13, 2023
Merged

Added max-width to legend to prevent long text from filling screen#394
jtroberts merged 2 commits into
developmentfrom
jr-maxwidth-legend

Conversation

@jtroberts

Copy link
Copy Markdown
Member

Purpose

  • I have legend values with long descriptive text that are expanding the legend to fill nearly the entire screen.

Proposed Changes

  • Added a max-width property to limit the expansion of text.

Issues

Testing

  • Tested different legends with various css values to find a good compromise.

@jtroberts jtroberts requested review from ac-61 and tariqksoliman July 13, 2023 00:06

@tariqksoliman tariqksoliman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It might be worthwhile to use text-overflow: ellipsis; and a title attribute too.

@jtroberts

Copy link
Copy Markdown
Member Author

@jtroberts jtroberts merged commit eb10fc4 into development Jul 13, 2023
@jtroberts jtroberts deleted the jr-maxwidth-legend branch July 13, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants