{{ message }}
Optional Info button for projects that need a link to project info #350#351
Merged
Conversation
tariqksoliman
approved these changes
Mar 7, 2023
Member
There was a problem hiding this comment.
Nice and LGTM!
Some minor and optional thoughts if you want:
- Hide the i and ? icons if a url is not configured
- Default the info to be off in the configuration (when it's unset)
- Use a solid circle information icon (because the info tool already uses the same i icon)
- Hide info and help icons if a url is not configured - Default the info button to be off in the configuration - Change to info icon with a circle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Optional Info button for projects that desire a link to general project info #350
Proposed Changes
Issues
Testing