{{ message }}
Repository navigation
🐛 Bugfix: Do not send chat message when Enter confirms IME composition - #4063
Open
Tomato-1101 wants to merge 1 commit into
Open
Tomato-1101 wants to merge 1 commit into
Tomato-1101 wants to merge 1 commit into
Conversation
Skip the Enter-to-send handler while an IME composition is active (isComposing, or keyCode 229 for Safari) and add a regression test. Fixes ModelEngine-Group#2783
Tomato-1101
requested review from
Dallas98,
WMC001,
YehongPan,
hhhhsc701 and
jeffwu-1999
as code owners
October 11, 2026 10:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2783
Symptom
In the chat input, pressing Enter to confirm an IME conversion (Japanese / Chinese / Korean, etc.) sends the half-typed message instead of just confirming the composition.
Root cause
handleKeyDowninfrontend/app/[locale]/chat/components/chatInput.tsxtreated every Enter keydown (without Shift) as "send" and did not check whether an IME composition was in progress.Fix
Return early from
handleKeyDownwhile composing:e.nativeEvent.isComposing || e.keyCode === 229(keyCode 229 covers Safari, which reportsisComposing=falseon the keydown right aftercompositionend).newchat/assistant-ui/composer.tsxis not affected: its input isComposerPrimitive.Inputfrom assistant-ui, which already ignores Enter during composition.Tests
frontend/tests/component/chatInputImeEnter.test.tsx(plain Enter sends; Shift+Enter does not; Enter withisComposingorkeyCode 229neither sends nor has its keydown cancelled, i.e.event.defaultPreventedstaysfalseso IME confirmation is not broken; the next plain Enter on the same input then sends exactly once). With the guard removed 2 of 4 fail (also when apreventDefault()is added to the guard); with the guard all pass.npx vitest run: 7 files, 43 tests passed.eslint/tsc --noEmit: no new errors (pre-existing ones are unchanged).This PR was prepared with AI assistance; I reviewed and tested the changes.