GEOPY-2893: h5 compression level seems ignore (from mira-omf) by domfournier · Pull Request #128 · MiraGeoscience/omf · GitHub
Skip to content

GEOPY-2893: h5 compression level seems ignore (from mira-omf)#128

Merged
sebhmg merged 9 commits into
release/GA_4.8from
GEOPY-2893
Jun 4, 2026
Merged

GEOPY-2893: h5 compression level seems ignore (from mira-omf)#128
sebhmg merged 9 commits into
release/GA_4.8from
GEOPY-2893

Conversation

@domfournier

@domfournier domfournier commented Jun 2, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

GEOPY-2893 - h5 compression level seems ignore (from mira-omf)

Copilot AI review requested due to automatic review settings June 2, 2026 16:57
@github-actions github-actions Bot changed the title GEOPY-2893 GEOPY-2893: h5 compression level seems ignore (from mira-omf) Jun 2, 2026
Copilot AI reviewed Jun 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GeoH5 serialization path to better honor HDF5 compression settings (and introduces a configurable HDF5 page size), while updating conversion tests to use GeoH5Writer directly instead of routing through OMFWriter.

Changes:

  • Switches geoh5 conversion tests from omf.OMFWriter(..., *.geoh5) to omf.GeoH5Writer(...).
  • Updates GeoH5Writer/conversion code to operate on active Workspace handles and passes compression into entity creation.
  • Adjusts the shared random_project test fixture (notably scaling up array sizes).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/convert_volume_test.py Updates volume conversion tests to use GeoH5Writer.
tests/convert_surface_test.py Updates surface conversion tests to use GeoH5Writer.
tests/convert_project_test.py Updates project conversion tests to use GeoH5Writer and adds compression/page size parameters.
tests/convert_pointset_test.py Updates pointset conversion tests to use GeoH5Writer.
tests/convert_grid2d_test.py Updates Grid2D conversion tests to use GeoH5Writer.
tests/convert_curve_test.py Updates curve conversion tests to use GeoH5Writer.
tests/conftest.py Changes the random_project fixture data sizes used across multiple tests.
omf/fileio/geoh5.py Refactors geoh5 writer/conversion plumbing around active workspaces; adds page-size support and compression propagation.
omf/fileio/fileio.py Changes OMFWriter behavior for output file handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread omf/fileio/geoh5.py Outdated
Comment thread omf/fileio/geoh5.py
Comment thread omf/fileio/fileio.py
Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py Outdated
sebhmg
sebhmg reviewed Jun 2, 2026
View reviewed changes
Comment thread poetry.lock Outdated
sebhmg
sebhmg reviewed Jun 2, 2026
View reviewed changes
Comment thread omf/fileio/fileio.py
sebhmg
sebhmg requested changes Jun 2, 2026
View reviewed changes

@sebhmg sebhmg left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks code, but need to relock to get proper geoh5py revision

@codecov

codecov Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.78%. Comparing base (32e1255) to head (1da7678).
⚠️ Report is 5 commits behind head on release/GA_4.8.

Files with missing lines Patch % Lines
omf/fileio/geoh5.py 87.75% 6 Missing ⚠️
omf/fileio/fileio.py 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           release/GA_4.8     #128      +/-   ##
==================================================
+ Coverage           92.15%   92.78%   +0.62%     
==================================================
  Files                  27       27              
  Lines                1505     1525      +20     
==================================================
+ Hits                 1387     1415      +28     
+ Misses                118      110       -8
Files with missing lines Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)
tests/convert_curve_test.py 100.00% <100.00%> (ø)
tests/convert_grid2d_test.py 100.00% <100.00%> (ø)
tests/convert_pointset_test.py 100.00% <100.00%> (ø)
tests/convert_project_test.py 100.00% <100.00%> (+29.26%) ⬆️
tests/convert_surface_test.py 100.00% <100.00%> (ø)
tests/convert_volume_test.py 100.00% <100.00%> (ø)
tests/script_geoh5_to_omf_test.py 100.00% <100.00%> (ø)
omf/fileio/fileio.py 90.78% <84.61%> (-1.22%) ⬇️
omf/fileio/geoh5.py 91.97% <87.75%> (-0.28%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebhmg sebhmg merged commit ebd135f into release/GA_4.8 Jun 4, 2026
30 checks passed
@sebhmg sebhmg deleted the GEOPY-2893 branch June 4, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@sebhmg sebhmg sebhmg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@domfournier @sebhmg