{{ message }}
Makefile.inc1: fix intermittent libmagic build failure under high parallelism#399
Merged
Conversation
libmagic links against -lz (LIBADD= z in lib/libmagic/Makefile) but Makefile.inc1 had no explicit lib/libmagic__L: lib/libz__L dependency. Under high parallelism (e.g. make -j28) libmagic could begin linking before libz was installed into the sysroot, producing: ld: error: unable to find library -lz *** [libmagic.so.4.full] Error code 1 All other libraries that link libz already have this dependency declared (libarchive, libssh, libzfs, libsqlite3, etc). Signed-off-by: Lucas Holt <luke@foolishgames.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Makefile.inc1 to declare a dependency for lib/libmagic__L on lib/libz__L. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/libmagic__L: lib/libz__Ldependency inMakefile.inc1lib/libmagic/MakefilehasLIBADD= zso libmagic must link-lz, but no__Lordering constraint was declared-j28(or any high-j), the linker step forlibmagic.so.4.fullcould race ahead oflibzbeing installed into the sysrootObserved failure:
All other libraries that depend on libz already have explicit
__Lconstraints (lib/libarchive__L,secure/lib/libssh__L,cddl/lib/libzfs__L,lib/libsqlite3__L, etc.). libmagic was simply overlooked.Test plan
make -j28 buildworldon amd64 — confirmlib/libmagicbuilds cleanly without the racemake -j4 buildworld— confirm no regression at lower parallelism🤖 Generated with Claude Code
Summary by Sourcery
Add a missing build dependency to ensure libmagic links against libz reliably under high parallelism.
Bug Fixes:
Build: