Remove definite article from "The AddressSanitizer" by Porges · Pull Request #4313 · MicrosoftDocs/cpp-docs · GitHub
Skip to content

Remove definite article from "The AddressSanitizer"#4313

Merged
colin-home merged 3 commits into
MicrosoftDocs:mainfrom
Porges:patch-1
Nov 30, 2022
Merged

Remove definite article from "The AddressSanitizer"#4313
colin-home merged 3 commits into
MicrosoftDocs:mainfrom
Porges:patch-1

Conversation

@Porges

@Porges Porges commented Nov 30, 2022

Copy link
Copy Markdown
Member

This is a proper noun and it reads as if we wrote "the Visual Studio" everywhere. There are probably other documents to update as well.

@prmerger-automator

Copy link
Copy Markdown
Contributor

@opbld31

opbld31 commented Nov 30, 2022

Copy link
Copy Markdown

Learn Build status updates of commit ee3dbbd:

✅ Validation status: passed

File Status Preview URL Details
docs/sanitizers/asan.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31

opbld31 commented Nov 30, 2022

Copy link
Copy Markdown

Learn Build status updates of commit d8c3fad:

✅ Validation status: passed

File Status Preview URL Details
docs/sanitizers/asan.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Avoid -ing verb forms. Prefer contractions. Avoid passive verb constructions.
@prmerger-automator

Copy link
Copy Markdown
Contributor

@Porges : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@opbld31

opbld31 commented Nov 30, 2022

Copy link
Copy Markdown

Learn Build status updates of commit 000485e:

✅ Validation status: passed

File Status Preview URL Details
docs/sanitizers/asan.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@colin-home colin-home left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Porges Thanks for the updates. I fiddled with them slightly to make our grammar checker happy.

@colin-home colin-home merged commit 2263ae5 into MicrosoftDocs:main Nov 30, 2022
Comment thread docs/sanitizers/asan.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants