Added workspaceContains:pyproject.toml to activationEvents#12056
Added workspaceContains:pyproject.toml to activationEvents#12056ericsnowcurrently merged 2 commits into
workspaceContains:pyproject.toml to activationEvents#12056Conversation
BrandonLWhite
force-pushed
the
workspaceContains-pyproject
branch
from
7f55d59 to
08615f2
Compare
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for the PR. Don't forget to add a news entry.
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
What issue is this for? We need a bit more discussion on the topic of file-based activation events (in package.json). For example, there are other files that are just as valid as markers for Python projects (requirements.txt, pytest.ini, etc.). Furthermore, note that we don't already have "workspaceContains:**/*.py" in the list. So a bit more discussion in a corresponding issue would be helpful.
|
Relates to Issue #4765 |
|
Understood. I've left a comment on #4765. |
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Can we please move forward with this and merge? If not, please advise as to what is blocking. |
|
I'm fine with the PR (though I'd suggest adding |
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
We'll also look at adding workspaceContains:setup.py in the near future.
|
Thanks @BrandonLWhite! |
4 participants
(for #4765)
This PR adds triggering off of 'pyproject.toml' in the workspace root to load the extension.
I'm hoping that using this standard file is easier to get merged vs. the "kitchen-sink" approach that has stalled another PR due to debates and disagreements.
Appropriate comments and documentation strings in the code.Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).