{{ message }}
chore: replace Prettier formatting with Oxfmt - #314
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
cryptodev-2s
force-pushed
the
migrate/pr2b-prettier
branch
from
September 4, 2026 06:52
db2cba6 to
791b881
Compare
Core formats with Oxfmt, so once this package moves into packages/ its files get reformatted by core's lint:misc regardless. Doing it here keeps that diff in a reviewable commit instead of landing as noise on top of the migrated git history. lint:misc prettier '**/*.json' '**/*.md' ... -> oxfmt --ignore-path .gitignore Adds .oxfmtrc.json copied from core, minus the merged-packages ignore, plus CHANGELOG.md which auto-changelog owns. Turns off prettier/prettier and import/order in .eslintrc.js, the same two rules and the same reason core gives: handled by Oxfmt. Drops prettier-plugin-packagejson, replaced by Oxfmt's sortPackageJson. The Prettier packages themselves stay and move to the versions core uses, because @metamask/eslint-config@15 peer requires all three: prettier ^2.7.1 -> ^3.3.3 eslint-config-prettier ^8.8.0 -> ^9.1.0 eslint-plugin-prettier ^4.2.1 -> ^5.2.1 Prettier also stays in use for `auto-changelog validate --prettier`. Reformatting touches README.md (list whitespace), src/json.ts and src/__fixtures__/bytes.ts. Build, 23 suites / 1993 tests, tsd and lint pass.
cryptodev-2s
force-pushed
the
migrate/pr2b-prettier
branch
from
September 4, 2026 07:16
791b881 to
bec22c8
Compare
^3.3.3 and interop deps
Mrtenz
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bottom of stack #315.
Core formats with Oxfmt, so once this package moves into
packages/its files get reformatted anyway. Doing it here keeps that diff reviewable instead of landing as noise on top of the migrated git history.lint:miscswitches from Prettier tooxfmt --ignore-path .gitignore.oxfmtrc.json, copied from coreprettier/prettierandimport/order, same as coreprettier-plugin-packagejson, replaced by Oxfmt'ssortPackageJsonPrettier itself stays, and moves to core's versions, because
@metamask/eslint-config@15peer requires all three:prettier^2.7.1^3.3.3eslint-config-prettier^8.8.0^9.1.0eslint-plugin-prettier^4.2.1^5.2.1Reformatting touches
README.md,src/json.tsandsrc/__fixtures__/bytes.ts. No content changes.