{{ message }}
Deserialize mutable collection interfaces with mutable concrete types#778
Merged
Conversation
neuecc
reviewed
Jan 17, 2020
neuecc
left a comment
neuecc
left a comment
Member
There was a problem hiding this comment.
Ok, but Add is better than Insert
For example: don't use a `T[]` to back an `IList<T>` since that blocks use of `IList<T>.Add` which probably worked before serialization. Fixes MessagePack-CSharp#253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example: don't use a
T[]to back anIList<T>since that blocks use ofIList<T>.Addwhich probably worked before serialization.Fixes #253