Check IsGenericType before call ConstructUnboundGenericType() by neuecc · Pull Request #2093 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Check IsGenericType before call ConstructUnboundGenericType()#2093

Merged
neuecc merged 1 commit into
masterfrom
fix-source-generator
Dec 12, 2024
Merged

Check IsGenericType before call ConstructUnboundGenericType()#2093
neuecc merged 1 commit into
masterfrom
fix-source-generator

Conversation

@neuecc

@neuecc neuecc commented Dec 11, 2024

Copy link
Copy Markdown
Member

fixed #2092
and add <IsRoslynComponent>true</IsRoslynComponent> for debugging.

@neuecc neuecc requested a review from AArnott December 11, 2024 03:25

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I didn't know about IsRoslynComponent before.

@neuecc

neuecc commented Dec 12, 2024

Copy link
Copy Markdown
Member Author

@neuecc neuecc merged commit 7639d75 into master Dec 12, 2024
@neuecc neuecc deleted the fix-source-generator branch December 12, 2024 07:25
This was referenced Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MessagePack v3 fails w/ "Warning CS8785 : Generator 'MessagePackGenerator' failed to generate source"

2 participants