Fix embedded types being generated in resolver by AlanLiu90 · Pull Request #2000 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Fix embedded types being generated in resolver#2000

Merged
AArnott merged 1 commit into
MessagePack-CSharp:developfrom
AlanLiu90:Branch_FixEmbeddedTypesGeneratedInResolver
Oct 15, 2024
Merged

Fix embedded types being generated in resolver#2000
AArnott merged 1 commit into
MessagePack-CSharp:developfrom
AlanLiu90:Branch_FixEmbeddedTypesGeneratedInResolver

Conversation

@AlanLiu90

Copy link
Copy Markdown
Contributor

The result of FormattableType.Name.Name is different from ITypeSymbol.ToString:

ITypeSymbol.ToString FormattableType.Name.Name
int int Int32
System.DateTime System.DateTime DateTime

It causes the branch handling embedded types becomes useless.

@AArnott AArnott added this to the v3.0 milestone Oct 14, 2024

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott merged commit 85c44d6 into MessagePack-CSharp:develop Oct 15, 2024
This was referenced Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants