{{ message }}
Fix handling of formatters following the singleton pattern#1850
Merged
Conversation
Because we can serialize internal and public members alike with AOT formatters, we require attributes on all of them alike.
This is because it can describe stock formatters as well as custom ones.
This was referenced Dec 2, 2025
This was referenced Jan 28, 2026
This was referenced Feb 20, 2026
This was referenced May 19, 2026
Open
This was referenced Jun 15, 2026
Merged
Merged
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we can serialize internal and public members alike with AOT formatters, we require attributes on all of them alike.