Fix source generator handling of inaccessible custom formatters by AArnott · Pull Request #1818 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Fix source generator handling of inaccessible custom formatters#1818

Merged
AArnott merged 1 commit into
developfrom
dev/andarno/fixes
May 16, 2024
Merged

Fix source generator handling of inaccessible custom formatters#1818
AArnott merged 1 commit into
developfrom
dev/andarno/fixes

Conversation

@AArnott

@AArnott AArnott commented May 15, 2024

Copy link
Copy Markdown
Collaborator

- Adds support for the singleton pattern in formatters (closes #1816).
- Nested, `private` formatters are now ignored and emit a `MsgPack010` warning instead of leading to generation of un-compilable code (fixes #1817).
@AArnott AArnott force-pushed the dev/andarno/fixes branch from 3b69f15 to 0dc68d7 Compare May 16, 2024 03:20
@AArnott AArnott merged commit 301b06f into develop May 16, 2024
@AArnott AArnott deleted the dev/andarno/fixes branch May 16, 2024 21:01
This was referenced Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant