Switch from MSBuild properties to an AdditionalFiles json file by AArnott · Pull Request #1667 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Switch from MSBuild properties to an AdditionalFiles json file#1667

Merged
AArnott merged 2 commits into
developfrom
fix1650
Aug 15, 2023
Merged

Switch from MSBuild properties to an AdditionalFiles json file#1667
AArnott merged 2 commits into
developfrom
fix1650

Conversation

@AArnott

@AArnott AArnott commented Aug 13, 2023

Copy link
Copy Markdown
Collaborator

This allows unity (which has no msbuild properties) to configure the source generator via a JSON file passed to the compiler via AdditionalFiles.

Closes #1650

@neuecc neuecc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's wonderful!

Would the URL for the example schema in the ReadMe be
https://raw.githubusercontent.com/MessagePack-CSharp/MessagePack-CSharp/master/MessagePackAnalyzer.schema.json ?
Also, I think it's fine that the schema.json serves as the document, but it might be nice to have a link to it.

@AArnott

AArnott commented Aug 14, 2023

Copy link
Copy Markdown
Collaborator Author

@neuecc

neuecc commented Aug 15, 2023

Copy link
Copy Markdown
Member

This allows unity (which has no msbuild properties) to configure the source generator.

Closes #1650
@AArnott AArnott enabled auto-merge August 15, 2023 12:54
@AArnott AArnott merged commit 3b8428e into develop Aug 15, 2023
@AArnott AArnott deleted the fix1650 branch August 15, 2023 13:08
This was referenced Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provides SourceGenerator option from AdditionalFiles

2 participants