MessagePack.Generator.csproj target to net7.0 by neuecc · Pull Request #1542 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

MessagePack.Generator.csproj target to net7.0#1542

Closed
neuecc wants to merge 2 commits into
masterfrom
mpc-update-net7
Closed

MessagePack.Generator.csproj target to net7.0#1542
neuecc wants to merge 2 commits into
masterfrom
mpc-update-net7

Conversation

@neuecc

@neuecc neuecc commented Dec 5, 2022

Copy link
Copy Markdown
Member

If only install dotnet sdk 7,0(does not install sdk 6.0)

image

mpc fail to get metadata so can't execute it.

image

using net7.0 success.

image

@AArnott require to change global.json and CI?

@neuecc neuecc requested a review from AArnott December 5, 2022 02:36
AArnott
AArnott approved these changes Dec 6, 2022
View reviewed changes

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised this change is necessary since we already have <RollForward>Major</RollForward> in this project file, but I have no objection to this change if it fixes the problem.

@AArnott

AArnott commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

@AArnott

AArnott commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

See #1543 for a fix for the PR build.

@AArnott

AArnott commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

Oh, I see now. The master branch still uses the .NET 6 SDK so you can't target .NET 7.
All our .NET 7 support is in the develop branch. In fact in the develop branch this project already includes a .NET 7 target:
https://github.com/neuecc/MessagePack-CSharp/blob/develop/src/MessagePack.Generator/MessagePack.Generator.csproj#LL6C55-L6C55

Will that suffice? I did ship a beta from the develop branch a few days ago (https://www.nuget.org/packages/MessagePack/2.5.64-alpha) so you can even try it out.

@github-actions

github-actions Bot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

@AArnott AArnott mentioned this pull request Mar 11, 2023
Merged
@AArnott AArnott closed this Mar 11, 2023
@AArnott AArnott deleted the mpc-update-net7 branch March 11, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AArnott AArnott AArnott approved these changes

Assignees

No one assigned

Labels

no-pr-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neuecc @AArnott