Support string interning when deserializing string as object. by sa-vg · Pull Request #1487 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Support string interning when deserializing string as object.#1487

Merged
AArnott merged 1 commit into
MessagePack-CSharp:developfrom
sa-vg:fix1484
Sep 6, 2022
Merged

Support string interning when deserializing string as object.#1487
AArnott merged 1 commit into
MessagePack-CSharp:developfrom
sa-vg:fix1484

Conversation

@sa-vg

@sa-vg sa-vg commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

@AArnott AArnott left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this change. It looks good. @neuecc, what do you think?
The validation failure is because AzDO custom build agents appear to fail with an SSL related issue. Maybe TLS-1.2 related. I'm looking into it.

@AArnott AArnott requested a review from neuecc August 23, 2022 12:37
@AArnott AArnott added this to the v2.5 milestone Sep 6, 2022
@AArnott AArnott merged commit 30243f1 into MessagePack-CSharp:develop Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strings are not interned on deserialization when the destination property type is object instead of string

2 participants