{{ message }}
Automata based member name lookup for improve string key deserialization#112
Merged
Conversation
Member
Author
Member
Author
Member
Author
AArnott
added a commit
to AArnott/MessagePack-CSharp
that referenced
this pull request
Mar 11, 2023
Drop netcoreapp2.1 as a target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Currently benchmark
Deserialization micro benchamark with BenchmarkDotNet. Target object has 9 members, value are zero.
IntKey, StringKey, Typeless_IntKey, Typeless_StringKey are MessagePack for C# options. JsonNetString/JilString is deserialized from string. JsonNetByteArray/JilByteArray is deserialized from UTF8 byte[]. Deserialization is normally read from Stream. Thus, it will be restored from
byte[]instead of string.MessagePack for C# IntKey is fastest. StringKey is slower than IntKey because matching from the character string is required. All MessagePack for C# options achive zero memory allocation on deserialization process.
StringKey deserialization is not so fast
The difference with IntKey is the cost of looking up a dictionary.
Jil uses automata-based-member-name-lookups technique.
It is good, can be improve string key deserialization performance.
Here is initial design's performance of automata.
I will do inlining of IL code generation, making it faster.