{{ message }}
Conversation
Three pages said the queue cascades failures through a Mergify stack: the
intro of the stacked pull requests page ("cascades failures so the rest of
the stack stops cleanly when something breaks"), the team guide ("cascades
dequeues if any predecessor fails") and the plain Git comparison ("a failure
cascades cleanly to the rest"). The cascade the Cascade Dequeue section
documents is the manual one: taking a PR out of the queue with
`@mergifyio dequeue`, the dashboard or the API dequeues every successor still
queued, under `stack-predecessor-dequeued`. A PR that fails its checks does
not take its successors out with that reason. The three sentences now say
what does happen.
The ask was to add a failed batch merge to the Cascade Dequeue section as an
automatic trigger. I checked the engine before writing that, and it does not
hold. The only automatic path that uses this reason covers GitHub-native
stack chains landed in a single merge call. When GitHub refuses that call,
the engine ejects the top PR of the chain, which has nothing above it, so no
successor is dequeued with it. Documenting that trigger would describe
something users never see, so the section keeps its manual triggers only.
Fixes Mergifyio/ci-bot#511
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I553550adb0308684a2d91623291b2922c8a4d7e7
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Remaining feedback is limited to minor wording nits and does not block approval.
Pull request overview
Updates stack documentation to clarify that cascade dequeues are manual queue-removal behavior, not failure propagation.
Changes:
- Corrects merge queue stack behavior descriptions.
- Updates team and plain Git comparison guidance.
- Clarifies effects on successors still in the queue.
File summaries
Review details
Suppressed comments (3)
src/content/docs/merge-queue/stacks.mdx:19
- This summary is still broad enough to imply that any dequeue—including the automatic
checks-failedremoval—cascades to successors, which is the behavior this change is correcting. Please distinguish a user-initiated dequeue and retain the condition that only successors still in the queue are affected.
up the stack, keeps stacked PRs together when batching, and dequeues the
PRs above any PR you take out of the queue.
src/content/docs/stacks/compare/plain-git.mdx:116
- The phrase “dequeueing a PR” still implies that any dequeue—including the automatic
checks-failedremoval—cascades, which contradicts the behavior this change is correcting. Please identify this as a manual dequeue and limit it to successors that are still queued.
bottom-up, and dequeuing a PR also dequeues the PRs above it. See
src/content/docs/stacks/team.mdx:99
- The phrase “dequeueing a PR” still implies that any dequeue—including the automatic
checks-failedremoval—cascades, which contradicts the behavior this change is correcting. Please identify this as a manual dequeue and limit it to successors that are still queued.
keeps stacked PRs together when batching, and dequeuing a PR also dequeues
the PRs above it. See [Stacked PRs in the Merge Queue](/merge-queue/stacks)
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three pages said the queue cascades failures through a Mergify stack: the
intro of the stacked pull requests page ("cascades failures so the rest of
the stack stops cleanly when something breaks"), the team guide ("cascades
dequeues if any predecessor fails") and the plain Git comparison ("a failure
cascades cleanly to the rest"). The cascade the Cascade Dequeue section
documents is the manual one: taking a PR out of the queue with
@mergifyio dequeue, the dashboard or the API dequeues every successor stillqueued, under
stack-predecessor-dequeued. A PR that fails its checks doesnot take its successors out with that reason. The three sentences now say
what does happen.
The ask was to add a failed batch merge to the Cascade Dequeue section as an
automatic trigger. I checked the engine before writing that, and it does not
hold. The only automatic path that uses this reason covers GitHub-native
stack chains landed in a single merge call. When GitHub refuses that call,
the engine ejects the top PR of the chain, which has nothing above it, so no
successor is dequeued with it. Documenting that trigger would describe
something users never see, so the section keeps its manual triggers only.
Fixes Mergifyio/ci-bot#511
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com