Embedded VectorStore Implementation(s) by edwinyyyu · Pull Request #1292 · MemMachine/MemMachine · GitHub
Skip to content

Embedded VectorStore Implementation(s) - #1292

Merged
malatewang merged 32 commits into
MemMachine:mainfrom
edwinyyyu:embedded_vector_store
May 2, 2026
Merged

Embedded VectorStore Implementation(s)#1292
malatewang merged 32 commits into
MemMachine:mainfrom
edwinyyyu:embedded_vector_store

Conversation

@edwinyyyu

@edwinyyyu edwinyyyu commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Purpose of the change

Add embedded implementations of VectorStore.

Description

Based on #1291.

One is based on SQLite + sqlite-vec (https://github.com/asg017/sqlite-vec).

  • sqlite-vec only works with SQLite that allows loading extensions, and does not support ANN yet.

One is based on SQLite + Vector Search Engine e.g.

Notes:

  • sqlite-vec is not usable OotB when the Python installation does not support loading SQLite extensions. This may be hard to debug for consumers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

[Please delete options that are not relevant.]

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

@edwinyyyu
edwinyyyu force-pushed the embedded_vector_store branch from 71e94b9 to 4a91d6b Compare April 2, 2026 08:14
@edwinyyyu edwinyyyu added this to the v0.3.5 milestone Apr 2, 2026
@edwinyyyu
edwinyyyu marked this pull request as draft April 3, 2026 00:00
@edwinyyyu edwinyyyu mentioned this pull request Apr 3, 2026
26 tasks
@edwinyyyu
edwinyyyu force-pushed the embedded_vector_store branch 2 times, most recently from e50560e to e155d0a Compare April 8, 2026 03:27
@edwinyyyu

Copy link
Copy Markdown
Contributor Author

@edwinyyyu

edwinyyyu commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

SEGFAULT caused by duplicate OpenMP runtimes, according to Claude.
Found: facebookresearch/faiss#3401

@edwinyyyu
edwinyyyu force-pushed the embedded_vector_store branch 11 times, most recently from bc7209c to a76acac Compare April 10, 2026 16:51
@edwinyyyu
edwinyyyu marked this pull request as ready for review April 10, 2026 19:10
@edwinyyyu

Copy link
Copy Markdown
Contributor Author

@edwinyyyu edwinyyyu added Integration An integration into a 3rd party framework or solution using MemMachine labels Apr 10, 2026
@sscargal sscargal modified the milestones: v0.3.5, v0.3.6 Apr 17, 2026
…EGFAULT

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
…work

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu
edwinyyyu force-pushed the embedded_vector_store branch from 3b8566c to 02539f5 Compare May 1, 2026 00:54
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@sscargal sscargal removed this from the v0.3.7 milestone May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration An integration into a 3rd party framework or solution using MemMachine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants