{{ message }}
Repository navigation
[TASK] Add Oshi support - #4224
Open
lolamtisch wants to merge 12 commits into
Open
lolamtisch wants to merge 12 commits into
lolamtisch wants to merge 12 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
There are confirmed TypeScript-breaking access modifier issues (supportsTags) and AnimeOshi list keying issues that can cause incorrect caching/progress behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
This PR adds a new sync provider, AnimeOshi, including OAuth flow, provider implementations (single/list/search/metadata), and integration into the webextension build + minimal UI. It also improves provider JSON parsing robustness via a shared parseJson helper and updates tag-handling to be optionally disabled per provider.
Changes:
- Add AnimeOshi provider end-to-end (OAuth page, API helper, single/list/search/meta providers, sync routing).
- Extend sync/type/slug resolution and minimal UI/provider lists to include
ANIMEOSHI. - Harden JSON parsing for provider helpers by using
parseJsonand add unit tests for it.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.