Fixed implementation for JKAnime by 36095 · Pull Request #4109 · MALSync/MALSync · GitHub
Skip to content

Fixed implementation for JKAnime - #4109

Open
36095 wants to merge 23 commits into
MALSync:masterfrom
36095:master
Open

36095 wants to merge 23 commits into
MALSync:masterfrom
36095:master

Conversation

@36095

@36095 36095 commented Jul 30, 2026

Copy link
Copy Markdown

MAL-Sync was broken on JKanime due to last year's changes in their UI.

This PR adds a new Chibi page implementation to support syncing anime progress from JKAnime, and registers it in the Chibi pages registry, adding compatibility with the changes made to their UI so it can be detected and loaded correctly by MAL-Sync.

Changes:

  • Removed legacy implementation
  • Registered a new JKAnime page in src/pages-chibi/pages.ts.
  • Added the JKAnime Chibi implementation (main.ts) with sync, lifecycle, and search URL.
  • Added basic test fixtures (tests.json) and shared styling import (style.less) for the new implementation.

Tested on multiple overview/sync pages, with and without: autoplay, fullscreen and autoresume.
Tested using only MyAnimeList sync bc I don't use the other ones.

P.S: I already did this fix a couple of days ago, but using the legacy implementation, thanks to lolamtisch for letting me know I had to use the new system ❤️.

Comment thread src/pages/list.json

@36095 36095 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't know that, sorry, fixing rn

…rlAbsolute, causing it to get the full overview page url

@lolamtisch lolamtisch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the old implementation did use them too. Could you go through all the selectors and improve them? Like this they will break with any mirror page change.

Comment thread src/pages-chibi/implementations/JKanime/main.ts Outdated
@36095
36095 requested a review from lolamtisch July 30, 2026 14:41
@lolamtisch lolamtisch added AI and removed New Website labels Aug 24, 2026
@36095

36095 commented Sep 1, 2026 •

Copy link
Copy Markdown
Author

@lolamtisch

lolamtisch commented Sep 2, 2026 •

Copy link
Copy Markdown
Member

Still the selectors could be less specific + quite specific expressions

@36095

36095 commented Sep 2, 2026

Copy link
Copy Markdown
Author

Still the selectors could be less specific + quite specific expressions

I'll try to make the selectors less specific, but can you elaborate in the 'expressions' part pls?

@lolamtisch

lolamtisch commented Sep 2, 2026 •

Copy link
Copy Markdown
Member

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants