refactor(cmd): split configure_azure.go by concern by cristim · Pull Request #2292 · LeanerCloud/cloud-commitments-cli · GitHub
Skip to content

refactor(cmd): split configure_azure.go by concern - #2292

Merged
cristim merged 6 commits into
mainfrom
refactor/1834-split-azure
Oct 20, 2026
Merged

cristim merged 6 commits into
mainfrom
refactor/1834-split-azure

Conversation

@cristim

@cristim cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member

Pure-move split of cmd/configure_azure.go into concern-focused files (part of #1834).

Part of #1834.

AST proof: a go/ast dump of every top-level declaration with its doc comment and free-floating comments across cmd/*.go (non-test) was byte-identical to origin/main at every commit (checked after each commit). go vet ./cmd/... and go test -count=1 ./cmd/... pass.

🤖 Generated with Claude Code

cristim and others added 4 commits October 20, 2026 19:59
…e.go

Pure move of newAzureWizardCredential and listAzureSubscriptions into configure_azure_subs.go. No behaviour change.

Part of #1834.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pure move of runAzureSetupCommands and the login, subscription and tenant steps into configure_azure_setup.go. No behaviour change.

Part of #1834.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ure.go

Pure move of azureStepCreateServicePrincipal and its result and recovery-hint helpers into configure_azure_sp_step.go. No behaviour change.

Part of #1834.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ure.go

Pure move of promptAndRunExplicitCommand and executeExplicitCommand into configure_azure_exec.go. No behaviour change.

Part of #1834.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

cristim and others added 2 commits October 20, 2026 20:30
The moved exec.Command calls live in configure_{gcp,azure}_{exec,setup}.go, so widen the per-file noctx exclusion to match.

Part of #1834.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Gate note (claude-cc-libs)

Head bb0663a is the reviewed 73f2d55 plus a merge of main after #2291. The .golangci.yml line is identical to the one #2291 landed, so it dropped out of the diff. Excluding CHANGELOG.md and .golangci.yml, the code diff is identical to the reviewed one.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

@cristim
cristim merged commit 6b83149 into main Oct 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant