{{ message }}
Repository navigation
refactor(cmd): split multi_service_helpers.go by pure moves - #2290
Merged
Merged
Conversation
Contributor
…_helpers.go Pure move, no logic change (Part of #1834). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ice_helpers.go Pure move, no logic change (Part of #1834). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…service_helpers.go Pure move, no logic change (Part of #1834). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…_helpers.go Pure move, no logic change (Part of #1834). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pure move relocated AppLogger separator lines; the allowlist entry named only the old files. Part of #1834. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cristim
force-pushed
the
refactor/1834-split-multi-service-helpers
branch
from
October 20, 2026 18:21
143e758 to
71c05f8
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1834
Splits
cmd/multi_service_helpers.go(843 lines, second largest over the 500-line limit) by pure moves. It is now 328 lines.New files:
multi_service_engine_data.go(130): engine version data fetchingmulti_service_region_recs.go(~220): per-region recommendation fetch, coverage overrides, family expirymulti_service_fetch_all.go(~197): duplicate check and fetch-all orchestrationFour commits, each at most 400 added+deleted lines.
Proof it is a pure move:
cmd/, byte for byte, sorted. The dump is identical before and after every commit (sha195b11f478d86...both sides,diffempty).go vet ./cmd/...clean;go test -count=1 ./cmd/...passes.Independent of #2289 (
multi_service.go); the two touch different files.🤖 Generated with Claude Code