{{ message }}
Repository navigation
fix(cli): make Enter skip resource-creating configure-gcp steps - #2249
Merged
Merged
Conversation
Empty input at the [R]un/[S]kip prompts ran the step, creating the service account, granting roles and minting a key. Empty input now skips; only r or run executes. Prompts read "[r]un, [S]kip (default)?". The gcloud auth login prompt follows the same rule. Unknown input already skipped. The "empty" IAM fixture scenario is removed (it asserted Enter runs); table tests cover "", r and s for every step against a stubbed Google API. Refs #1613 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cristim
added
priority/p3
Contributor
Member
Author
Independent review verdict: CLEAN at ec929b0Reviewer: fresh Claude agent (Sonnet, high effort), not the author, cold brief. The PR body was treated as a claim. Coordinator: claude-cc-reviewer. Blocking findings: none. No step that creates or changes a resource still runs on Enter.
Non-interactive input:
Prompt text, CHANGELOG and docs:
Notes (non-blocking):
What was attacked and how (no GCP calls):
Gate: no closing issue, and the PR carries its own triage labels. Merge once CI is green and the CodeRabbit gate is met. |
Member
Author
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1613. This covers the GCP half of finding A10-030. The Azure half (
cmd/configure_azure.go) follows after the open #2212 lands, since that PR touches the same file.Summary
In the
configure-gcpwizard, pressing Enter at a[R]un, [S]kip?prompt ran the step: it created the service account, granted roles, minted a key, or rangcloud auth login/ ADC login. A stray Enter therefore made real changes to cloud identities.""moved from the run case to the skip case at each one:promptAndRunGCPCommand, which handles auth and ADC login[r]un, [S]kip (default)?. Enter prints the step's normal skip message rather than "Unknown option". Unknown input already skipped, so its behaviour is unchanged.docs/cli/cloud-setup.mdandCHANGELOG.mddescribe the new default.configure_gcp_iam_test.go"empty" scenario asserted the old Enter-runs behaviour, so it is removed. It was otherwise identical to the "create" scenario. The wizard-driving fixtures already send an explicitr.Evidence (local, macOS,
GOTOOLCHAIN=go1.26.9, stubbed Google API, no GCP calls)cmd/configure_gcp_default_skip_test.godrives"",randsthrough all four steps.configure_gcp.go, the four empty-input cases fail.""back on the run case failscreate-key/emptyandTestPromptAndRunGCPCommand_DefaultIsSkip.make buildpasses.go vet ./...passes.go test -race ./cmd/passes (1568) on the rebased tree.-count=3 -race.scripts/test-git-secrets-allowlist.shpasses 44/44.""run-defaults remain inconfigure_gcp.goand that no coverage was lost.🤖 Generated with Claude Code