{{ message }}
Repository navigation
chore(pre-commit): pin hook revisions to SHAs and align the gocyclo threshold - #2241
Merged
Merged
Conversation
… actionlint Pin pre-commit-hooks v6.0.0 and markdownlint-cli v0.47.0 to the commit SHAs their tags resolve to. The actionlint hook (digest-pinned image) is already present, so no hook is added. Align the golangci gocyclo threshold with the enforcing gates (-over 10); no new findings. Refs #1594 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cristim
added
priority/p3
Contributor
Member
Author
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1594. This covers the tooling items. Dependabot/Renovate and CODEOWNERS stay open as an owner decision.
Summary
Pinned the third-party pre-commit hooks to commit SHAs. Before, they referenced mutable tags. Both tags are lightweight, so each SHA is the tagged commit itself:
pre-commit/pre-commit-hooksv6.0.0 →3e8a8703264a2f4a69428a0aa4dcb512790b2c8cigorshubovych/markdownlint-cliv0.47.0 →76b3d32d3f4b965e1d6425253c59407420ae2c43The version stays as a trailing comment, which is the format
pre-commit autoupdatekeeps. Every other hook isrepo: localor a digest-pinned image.Aligned the golangci gocyclo threshold with the enforcing gates.
.golangci.ymlhadmin-complexity: 15, whileMakefile:73,ci.yml:75and the pre-commit gocyclo hook use-over 10. Both now flag complexity above 10, since golangci filters with the same "over" boundary. Lowering it to 10 adds no new findings.actionlint: already on main as a digest-pinned docker hook scoped to
.github/workflows/. chore: prune monorepo residue from config and docs #2234 already removed the check-yaml workflow exclude. Nothing new was needed here, and actionlint passes on the current workflows.Evidence (local, macOS)
pre-commit run --all-filespasses, including the re-pinned hooks and actionlint.min-complexity: 10.scripts/test-git-secrets-allowlist.shpasses 44/44, andmake buildpasses.pre-commit run --all-filesis unchanged. The pins only rebuild the cached hook environments.git ls-remote;🤖 Generated with Claude Code
Summary by CodeRabbit