{{ message }}
Repository navigation
fix(gcp): restrict setup wizard compute permissions - #2122
Merged
Merged
Conversation
Replace the setup wizard's Compute Admin grant with Compute Viewer and an exact project custom role for compute.commitments.create. Preserve conditional access and fail rather than silently widening existing grants. Cover the real SDK policy requests and wizard failure exits with local HTTP fixtures. Existing broad grants require separate operator review.
Contributor
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

configure-gcpcurrently grants full Compute Admin access before minting a service-account key. Replace that grant with Compute Viewer and a project custom role containing onlycompute.commitments.create.The wizard validates existing custom roles before binding them and refuses to widen conditional-only membership. It preserves existing grants, including broad grants from older installations, which need separate operator review. Setup documentation distinguishes operator permissions from runtime permissions and notes separate Recommender access requirements.
Validation uses the real wizard coordinator and Google SDK against local HTTP fixtures. The regression fails on the original Compute Admin policy request. Cases cover custom-role reuse and rejection, preserved conditional and broad grants, create conflicts, and partial policy-write failure before key minting. No live IAM mutation or purchase was performed; fixture evidence does not establish live Google IAM propagation.
Verified commit:
1272e721b8d5185634840c9aa9fc7698dd7cb124.Closes #1946
Summary by CodeRabbit