fix(frontend/recs): return null from effectiveSavingsPct on AWS reconstruction fallback (followup to #321) · Issue #323 · LeanerCloud/cloud-commitments-cli · GitHub
Skip to content

fix(frontend/recs): return null from effectiveSavingsPct on AWS reconstruction fallback (followup to #321) #323

Closed

Description

@cristim

Once #321's migration ships and the next collector tick repopulates on_demand_cost for AWS rows, evaluate whether to make effectiveSavingsPct return null when the reconstruction fallback would fire on AWS rows — so the UI renders '—' rather than a silently-wrong percentage. Wait until production data confirms the migration succeeded before deciding.

Closes the optional follow-up flagged in #321's fix plan (item 4 in the fix plan).

Activity

  1. cristim commented on May 28, 2026

    @cristim
    MemberAuthor

    Verification: cannot-verify-autopilot. The input bucket linked PR #324, but that PR closes #321 (the on_demand_cost cache flush migration). Issue #323 is a deliberate follow-up: 'wait until production data confirms the migration succeeded before deciding' whether to return null from effectiveSavingsPct on AWS reconstruction fallback. The decision has not been made and no commit closes this issue on origin/feat/multicloud-web-frontend. The effectiveSavingsPct null-return fix exists on branch origin/fix/issue-252-monthly-cost-effective-pct but is not yet merged. Leaving open.

  2. added 5 commits that reference this issue on Jun 3, 2026
    fd57662
    e0bbd18
    a6f4069
    1fa33c0
    763f4ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions