test(gcp): audit mock harness vs production client lifecycle (memorystore/cloudsql) · Issue #251 · LeanerCloud/cloud-commitments-cli · GitHub
Skip to content

test(gcp): audit mock harness vs production client lifecycle (memorystore/cloudsql) #251

Closed

Description

@cristim

Address pre-existing GCP memorystore/cloudsql test failures stemming from mock-service infrastructure.

Symptoms:

  • memorystore: asserts mockService.closeCalled == true, but Close() is never invoked by the production GetExistingCommitments path under test.
  • cloudsql: expects an error from ValidateOffering when no credentials are present, but the call returns nil.

Reference PR #91.

Activity

  1. added a commit that references this issue on May 27, 2026
    46b48c5
  2. cristim commented on May 28, 2026

    @cristim
    MemberAuthor

    Verified shipped: merge commit 46b48c5 (PR #584) is in origin/feat/multicloud-web-frontend (compare API: feat is ahead of 46b48c5). PR #584 body says "Closes #251" and aligns the GCP mock harness with the production client lifecycle for memorystore/cloudsql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions