Repository navigation
INF-04: ci.yml E2E job can never pass (missing --profile test) and continue-on-error permanently masks the failure #1180
Description
Severity: P3 (downgraded from P2 by the verifier). Confidence: high.
Affected files:
.github/workflows/ci.yml:371-376.github/workflows/ci.yml:391-395docker-compose.test.yml:111-112
Evidence:
ci.yml runs docker-compose -f docker-compose.test.yml up --abort-on-container-exit --exit-code-from test-runner without --profile test, but test-runner is profile-gated, so the referenced service never starts and the command errors. The job is continue-on-error: true with the stale comment "Dockerfile.test and docker-compose.test.yml are not yet implemented" even though both files exist. The legacy docker-compose v1 binary is also not guaranteed on current ubuntu-latest runners.
Impact:
The E2E suite has never gated a merge. Largely mitigated: the masking is documented in the workflow, and the separate fully-gating integration-tests job runs essentially the same suite against real Postgres; the unique coverage lost is the containerized-HTTP-app variant.
Recommendation:
Switch to docker compose ... --profile test up ..., delete the stale comment, and remove continue-on-error once verified green so the job actually gates.
Verifier verdict: downgraded to P3 - real latent defect plus stale comment, but acknowledged CI hygiene debt with near-equivalent gating coverage elsewhere.
Source: docs/reviews/codebase-review-2026-06-10.md (automated multi-dimension code review, adversarially verified for P1/P2)
Activity
ci(e2e): run profile-gated compose E2E suite for real (refs #1180)
cristim commentedon Jul 27, 2026
Verification sweep against
main(101f099fb) on 2026-07-27 finds this already resolved.The e2e job now runs with
--profile test, continue-on-error has been removed, and it gates ci-success.Evidence: commit 877653d.
Recommending close.
cristim commentedon Sep 2, 2026
Verified resolved at 3c0f8ac: the e2e-tests job now invokes
docker compose -f docker-compose.test.yml --profile testfor build, up and down, the stale "not yet implemented" comment is gone, the job has no continue-on-error, and ci-success depends on it so it gates merges. Evidence: .github/workflows/ci.yml:856-867 (commit 877653d, "ci(e2e): run profile-gated compose E2E suite for real"). Residual axes checked: the only remaining continue-on-error in ci.yml (:829) is on the Snyk step of the snyk-scan job, unrelated; docker-compose.test.yml still profile-gates test-runner and every compose call passes the profile; e2e-tests is in the ci-success needs list. Closing as completed; reopen if the behaviour recurs.ci(e2e): run profile-gated compose E2E suite for real (refs #1180)