Improve Gradle files by mickele · Pull Request #317 · KeepSafe/TapTargetView · GitHub
Skip to content

Improve Gradle files#317

Merged
xiphirx merged 3 commits into
KeepSafe:masterfrom
mickele:feature/improve-gradle-files
Oct 2, 2018
Merged

Improve Gradle files#317
xiphirx merged 3 commits into
KeepSafe:masterfrom
mickele:feature/improve-gradle-files

Conversation

@mickele

@mickele mickele commented Oct 1, 2018

Copy link
Copy Markdown
Contributor

This PR will change minor gradle things like:

  • Change double quotes to single quotes (this is already the code style for the project, except for those places where this change was applied)
  • Define the minSdkVersion at a single place (this was already done with the compileSdkVersion)
  • Upgrade gradle version to 4.10.2 (minor upgrade change to latest, also using "all" version instead of "bin" so AS stops complaining about documentation and other stuff)

There's should be no effect on the end library from this PR.

Also use the "all" version instead of "bin" so Android Studio stops complaining about documentation.
This was already done for some configuration variables like `defCompileSdkVersion`.
This is to make it concise with other gradle files.
@xiphirx xiphirx merged commit a5f4288 into KeepSafe:master Oct 2, 2018
@xiphirx

xiphirx commented Oct 2, 2018

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants