Fix transparent target in Android P by hearsilent · Pull Request #314 · KeepSafe/TapTargetView · GitHub
Skip to content

Fix transparent target in Android P#314

Closed
hearsilent wants to merge 5 commits into
KeepSafe:masterfrom
hearsilent:fix_28.0.0
Closed

Fix transparent target in Android P#314
hearsilent wants to merge 5 commits into
KeepSafe:masterfrom
hearsilent:fix_28.0.0

Conversation

@hearsilent

@hearsilent hearsilent commented Sep 28, 2018

Copy link
Copy Markdown
Contributor

Fix #313

Screenshots

TargetSdk 28 Android P (Origin)

TargetSdk 28 Android P (Fixed)

Upgrade libraries

  • Upgrade gradle plugin to 3.2.0
  • Upgrade gradle to 4.10.0
  • Upgrade build tools to 28.0.3
  • Upgrade compile sdk to 28
  • Upgrade target sdk to 28

- Upgrade gradle plugin to 3.2.0
- Upgrade gradle to 4.6.0
- Upgrade build tools to 28.0.3
- Upgrade support library to 28.0.0
- Upgrade compile sdk to 28
- Upgrade target sdk to 28
@hearsilent

Copy link
Copy Markdown
Contributor Author

@hearsilent hearsilent changed the title Fix transparent target in support library 28.0.0 Fix transparent target in Android P Oct 1, 2018
@hearsilent

Copy link
Copy Markdown
Contributor Author

@xiphirx Fixed conflicts.

@xiphirx

xiphirx commented Oct 1, 2018

Copy link
Copy Markdown
Collaborator

Thanks for raising the issue, the bug here is actually different, see #315

@xiphirx xiphirx closed this Oct 1, 2018
@hearsilent

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants