{{ message }}
CI benchmarking suite#533
Closed
MilesCranmer wants to merge 20 commits into
Closed
Conversation
Contributor
Author
ericphanson
reviewed
Aug 2, 2024
Contributor
Author
|
Here's the new results, comparing #529 with main:
Does this make sense? A bit slower GC, but now with thread safety? |
ericphanson
reviewed
Aug 2, 2024
Contributor
Author
|
Hey @cjdoris I updated to the proper workflow version of AirspeedVelocity.jl: https://discourse.julialang.org/t/easy-github-benchmarking-with-new-airspeedvelocity-jl/129327. It uses a job summary. You can see the benchmark results here. Using this, one can quickly check this table on a PR to validate if a change hasn't caused a slowdown or anything. It also now reports memory and allocations which has been useful! (We can also switch to the GitHub comment version if you prefer.) Does this sound good to you? |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Merge after #618)
This defines a simple BenchmarkTools.jl suite based on BENCHMARKS.md for the actual benchmark code. Feel free to add other things we should be keeping track of or maybe some integration benchmarks.
This also uses AirspeedVelocity.jl for automatic CI output which parses the output of the benchmark results. Basically every pull request will get a comment like SymbolicML/DynamicExpressions.jl#94 (comment) with all of the performance info. It also measures the change in load time which is quite useful.
I find it nice for catching performance regressions in PRs.