{{ message }}
feat(ui): add JContainer component with max-width constraints#613
Merged
Conversation
Add responsive container component following Tailwind/Bootstrap patterns: - JContainer with ContainerSize enum (Xs/Sm/Md/Lg/Xl/Full) - Fluent API: WithSize(), WithHorizontalPadding(), WithResponsivePadding(), Fluid() - Container tokens in Tokens.cs (480/640/768/1024/1280px) - CSS classes for styling: j-container--xs/sm/md/lg/xl/full - Wrap PanelUI and BootstrapEditorUI content in JContainer(Xs) - Rename .j-container to .j-panel-base in base.uss to avoid conflicts Also adds unit testing requirements to coding guidelines and comprehensive tests for JContainer (45+ test cases covering all functionality). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
github-actions
Bot
added
documentation
There was a problem hiding this comment.
Pull request overview
This PR adds a responsive JContainer layout component that provides max-width constraints and horizontal centering for Unity Editor UI, following Tailwind CSS container patterns.
Changes:
- Adds
JContainercomponent with configurable size constraints (Xs, Sm, Md, Lg, Xl, Full) and fluent API methods for responsive layouts - Wraps PanelUI and BootstrapEditorUI content in
JContainer(ContainerSize.Xs)to create centered, compact layouts - Updates coding guidelines to require unit tests for non-core packages (JEngine.UI, JEngine.Util) with comprehensive documentation and examples
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
Unity Test Results✅ EditMode: All tests passed Unity Version: 2022.3.55f1 ✅ All tests passed! The PR is ready for review. View workflow run |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 85.01% 90.35% +5.33%
==========================================
Files 60 65 +5
Lines 7683 8684 +1001
==========================================
+ Hits 6532 7846 +1314
+ Misses 1151 838 -313 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JContainercomponent with max-width constraints following Tailwind/Bootstrap patternsContainerSizeenum with sizes: Xs (480px), Sm (640px), Md (768px), Lg (1024px), Xl (1280px), Full (no limit)WithSize(),WithHorizontalPadding(),WithResponsivePadding(),Fluid()PanelUIandBootstrapEditorUIcontent inJContainer(ContainerSize.Xs)for centered, constrained layoutsTest plan
🤖 Generated with Claude Code