Fix binary extraction flow by rishabh-sagar-20 · Pull Request #7 · JSv4/Python-Redlines · GitHub
Skip to content

Fix binary extraction flow#7

Merged
JSv4 merged 2 commits into
JSv4:mainfrom
SpotDraft:fix-binary-extraction-flow
Apr 2, 2024
Merged

Fix binary extraction flow#7
JSv4 merged 2 commits into
JSv4:mainfrom
SpotDraft:fix-binary-extraction-flow

Conversation

@rishabh-sagar-20

Copy link
Copy Markdown
Contributor

Refactor:

  • Fix Binary Extraction in XmlPowerToolsEngine - The binary extraction flow is broken and will not extract binaries unless fixed. This PR fixes this bug.

Update:

  • Added MacOS Binary Build Instructions to Developer's Guide

The code has been updated to include support for macOS in the build and extraction process of the project. A new section is added to perform build and compression for macOS, in addition to existing mechanisms for Windows and Linux. The extraction method in engines.py is also modified to handle macOS specific binaries.
@rishabh-sagar-20 rishabh-sagar-20 changed the title Add support for macOS in build and extraction process Fix binary extraction flow Apr 2, 2024

@JSv4 JSv4 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice, clean improvement.

@JSv4 JSv4 merged commit 4ee2e99 into JSv4:main Apr 2, 2024
@JSv4

JSv4 commented Apr 2, 2024

Copy link
Copy Markdown
Owner

@rishabh-sagar-20

Copy link
Copy Markdown
Contributor Author

It's feasible. Additionally, we can create distinct builds for each platform. By doing so, you can circumvent size constraints and upload it to PyPi.

@rishabh-sagar-20

Copy link
Copy Markdown
Contributor Author

What's the overall size? I came across a page stating that we can discuss with PyPi to waive the size limit.
Ref:

  1. https://pypi.org/help/#file-size-limit
  2. StackOverflow

@JSv4

JSv4 commented Apr 2, 2024

Copy link
Copy Markdown
Owner

Yes, I did see that, but it seems the limit is 60 MB (compressed) and the binaries (at least on my machine) are about 65 - 80 MB each.

@rishabh-sagar-20

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants