Update `broadcast_arrays` to return a tuple instead of a list by vlad-perevezentsev · Pull Request #2944 · IntelPython/dpnp · GitHub
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
12 changes: 6 additions & 6 deletions dpnp/dpnp_iface_manipulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1060,8 +1060,8 @@ def broadcast_arrays(*args, subok=False):

Returns
-------
out : list of dpnp.ndarray
A list of arrays which are views on the original arrays from `args`.
out : tuple of dpnp.ndarray
A tuple of arrays which are views on the original arrays from `args`.

Limitations
-----------
Expand All @@ -1078,20 +1078,20 @@ def broadcast_arrays(*args, subok=False):
>>> x = np.array([[1, 2, 3]])
>>> y = np.array([[4], [5]])
>>> np.broadcast_arrays(x, y)
[array([[1, 2, 3],
(array([[1, 2, 3],
[1, 2, 3]]), array([[4, 4, 4],
[5, 5, 5]])]
[5, 5, 5]]))

"""

if subok is not False:
raise NotImplementedError(f"subok={subok} is currently not supported")

if len(args) == 0:
return []
return ()

usm_arrays = dpt.broadcast_arrays(*[dpnp.get_usm_ndarray(a) for a in args])
return [dpnp_array._create_from_usm_ndarray(a) for a in usm_arrays]
return tuple(dpnp_array._create_from_usm_ndarray(a) for a in usm_arrays)


def broadcast_shapes(*args):
Expand Down
6 changes: 3 additions & 3 deletions dpnp/tensor/_manipulation_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ def broadcast_arrays(*args):
broadcasted.

Returns:
List[usm_ndarray]:
A list of broadcasted arrays. Each array
tuple[usm_ndarray, ...]:
A tuple of broadcasted arrays. Each array
must have the same shape. Each array must have the same `dtype`,
`device` and `usm_type` attributes as its corresponding input
array.
Expand All @@ -245,7 +245,7 @@ def broadcast_arrays(*args):
if all(X.shape == shape for X in args):
return args

return [broadcast_to(X, shape) for X in args]
return tuple(broadcast_to(X, shape) for X in args)


def broadcast_to(X, /, shape):
Expand Down
2 changes: 1 addition & 1 deletion dpnp/tests/test_arraymanipulation.py
Loading