{{ message }}
Disallow scalar conversation for non-0D arrays#2223
Merged
Conversation
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_103 ran successfully. |
Collaborator
antonwolfy
reviewed
Dec 22, 2025
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_108 ran successfully. |
ndgrigorian
reviewed
Jan 8, 2026
ndgrigorian
reviewed
Jan 8, 2026
ndgrigorian
reviewed
Jan 8, 2026
ndgrigorian
previously approved these changes
Jan 8, 2026
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
aside from minor comments this LGTM
vlad-perevezentsev
changed the title
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_109 ran successfully. |
7 tasks
antonwolfy
added a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 12, 2026
This PR is aimed to unblock the CI and to temporary mute tests failing with numpy 2.4. The changes needs to be reverted once [dpctl-2223](IntelPython/dpctl#2223) is merged and dpnp tests will be updated appropriately.
github-actions Bot
added a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 12, 2026
This PR is aimed to unblock the CI and to temporary mute tests failing with numpy 2.4. The changes needs to be reverted once [dpctl-2223](IntelPython/dpctl#2223) is merged and dpnp tests will be updated appropriately. 36dde9e
ndgrigorian
approved these changes
Jan 13, 2026
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks @vlad-perevezentsev
7 tasks
antonwolfy
pushed a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 14, 2026
This PR updates dpnp tests for non-0D scalar conversion behavior changes in [dpctl-2223](IntelPython/dpctl#2223) - allowing scalar conversion only for 0D `usm_ndarray`
github-actions Bot
added a commit
to IntelPython/dpnp
that referenced
this pull request
Jan 14, 2026
This PR updates dpnp tests for non-0D scalar conversion behavior changes in [dpctl-2223](IntelPython/dpctl#2223) - allowing scalar conversion only for 0D `usm_ndarray` 8c56923
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns
usm_ndarrayscalar conversion semantics with the Python Array API by allowing scalar conversion only for 0D usm_ndarraysConversions to Python numeric scalars via
int,float,complex,bool, and their corresponding methods (__int__,_float__,__complex__, bool) now raiseTypeErrorwhen applied to usm_ndarrays withndim !=0`