Fix logic managing dll search path and path when initializing dpctl by ndgrigorian · Pull Request #2130 · IntelPython/dpctl · GitHub
Skip to content

Fix logic managing dll search path and path when initializing dpctl#2130

Merged
ndgrigorian merged 1 commit into
masterfrom
fix-dpctl-import-from-venv-windows
Aug 11, 2025
Merged

Fix logic managing dll search path and path when initializing dpctl#2130
ndgrigorian merged 1 commit into
masterfrom
fix-dpctl-import-from-venv-windows

Conversation

@ndgrigorian

@ndgrigorian ndgrigorian commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

This PR refactors some logic in dpctl managing the DLL search path, also adding the dpctl __init__.py directory to the PATH, matching the logic in dpnp, in an attempt to fix dpctl being imported from virtual environments failing to see devices or find SYCL dlls

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_93 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@coveralls

coveralls commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 85.902% (+0.02%) from 85.878%
when pulling 2680eb8 on fix-dpctl-import-from-venv-windows
into 3381d14 on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review August 5, 2025 21:22
antonwolfy
antonwolfy previously approved these changes Aug 5, 2025
View reviewed changes

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian for resolving the issue

@ndgrigorian ndgrigorian force-pushed the fix-dpctl-import-from-venv-windows branch from b898be9 to 2680eb8 Compare August 5, 2025 21:38
@ndgrigorian ndgrigorian requested a review from antonwolfy August 5, 2025 21:38
@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_93 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@desmondsow

desmondsow commented Aug 11, 2025

Copy link
Copy Markdown

@ndgrigorian ndgrigorian merged commit 8ae6272 into master Aug 11, 2025
68 of 89 checks passed
@ndgrigorian ndgrigorian deleted the fix-dpctl-import-from-venv-windows branch August 11, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes
@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner
@vtavana vtavana Awaiting requested review from vtavana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndgrigorian @coveralls @desmondsow @antonwolfy