{{ message }}
Update HIP target handling using alias#2099
Merged
Merged
Conversation
vlad-perevezentsev
requested review from
antonwolfy,
ndgrigorian and
vtavana
as code owners
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_22 ran successfully. |
ndgrigorian
previously approved these changes
Jun 9, 2025
ndgrigorian
left a comment
ndgrigorian
left a comment
Collaborator
There was a problem hiding this comment.
This LGTM overall
After this and the CUDA architecture update are merged, I think allowing setting CUDA and HIP architecture as arguments to scripts/build_locally.py script would be convenient
vlad-perevezentsev
force-pushed
the
update_amd_build
branch
from
76c7bab to
73e4c90
Compare
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_41 ran successfully. |
Collaborator
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_42 ran successfully. |
ndgrigorian
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests simplifying
DPCTL_TARGET_HIPhandling by using target aliasesamd_gpu_<arch>and removing support foramdgcn-amd-amdhsatarget.Also updates
docsto clarify how to determine and use the correct AMD GPU architecture.