Correct a path to `cl.cfg` file by antonwolfy · Pull Request #2068 · IntelPython/dpctl · GitHub
Skip to content

Correct a path to cl.cfg file#2068

Merged
ndgrigorian merged 1 commit into
masterfrom
update-path-to-cl.cfg
Apr 30, 2025
Merged

Correct a path to cl.cfg file#2068
ndgrigorian merged 1 commit into
masterfrom
update-path-to-cl.cfg

Conversation

@antonwolfy

@antonwolfy antonwolfy commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

The location of cl.cfg file created by installing intel-opencl-rt conda package has been changed few releases back from %CONDA_PREFIX%\Library\lib\cl.cfg to %CONDA_PREFIX%\Library\bin\cl.cfg.
The file is still created at Library\lib\cl.cfg path by intel-opencl-rt-post-link.bat script but with empty content.

The PR updates public CI to rely on correct path towards cl.cfg configuration file.
The issue with intel-opencl-rt-post-link.bat script has to be updated by a separate PR in the compiler repo.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 30, 2025
@antonwolfy

antonwolfy commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator Author

@github-actions

github-actions Bot commented Apr 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions

github-actions Bot commented Apr 30, 2025

Copy link
Copy Markdown

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_173 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@coveralls

coveralls commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 86.419%. remained the same
when pulling c8700ce on update-path-to-cl.cfg
into b7a6b67 on master.

@ndgrigorian

ndgrigorian commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

@antonwolfy
Tests pass so it's probably fine, but I'm surprised we never saw the same warnings in dpctl as dpnp, do you know why?

@antonwolfy

antonwolfy commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator Author

@ndgrigorian ndgrigorian merged commit 29eeac7 into master Apr 30, 2025
@ndgrigorian ndgrigorian deleted the update-path-to-cl.cfg branch February 6, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes
@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner
@vtavana vtavana Awaiting requested review from vtavana

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @ndgrigorian